Questions For Walkthroughs

One list (from Handbook of Walkthroughs, Inspections, and Technical Reviews by Freedman and Weinberg):

Function

  1. Is there a concept, an underlying idea, that can be expressed easily in plain language? Is it expressed in plain language in the implemented code?
  2. Does the function of this part have a clear place in the overall function of the whole, and is this function clearly expressed?
  3. Is the routine properly sheltered, so that it may perform its function reliably in spite of possible misuse?

Form

  1. Whatever style is adopted, is it clean and clear when taken as a whole?
  2. Is it meaningful to all classes of readers who will see it?
  3. Are there repeated code segments, whether within or between routines?
  4. Are comments useful or are they simply alibis for poor coding?
  5. Is the level of detail consistent?
  6. Are standard practices used?
  7. Is initialization properly done, and does the routine clean up after itself?

Economy

  1. Are there redundant operations for which there is no compensating benefit?
  2. Is storage use consistent, both internally and with external specifications?
  3. How much will it cost to modify? (Consider the three most likely future modifications.) [my addition--and consider the three most likely future mistakes in modification]
  4. Is it simple?
For a checklist of the process of holding a walkthrough, see Checklist for Code Walkthroughs