XVM Code Review Policy

In order to maintain a high quality of service for XVM, this document
establishes the means by which code is vetted for deployment by XVM
Maintainers (xvm-root@mit.edu) and XVM Developers (xvm-dev@mit.edu).

Before it is deployed, *all code must be reviewed* by at least one XVM
Developer other than the author.  Code reviews must happen over
e-mail, as replies to the commit notification, and copying either
xvm@mit.edu or invirt@mit.edu.  When a Maintainer deploys code, it
must have been sufficiently reviewed that the Maintainer is confident
in its correctness, and any outstanding objections must have been
resolved.

To avoid creating obstacles for contributors, the Maintainers must
accept responsibility for reviewing all code submissions in a timely
fashion.  Other Developers should also participate in reviews to
further this goal.

While the primary responsibility for a change falls on the original
author of a change and the Maintainer who deploys it, all reviewers
share some responsibility.  If a change is determined to be
problematic, all authors and reviewers are expected to contribute to
either fixing the change or backing it out.

This policy should not be a barrier to making changes in emergencies.
XVM Maintainers are expected to carefully exercise discretion, but
they also have broad authority to make code and configuration changes
in an emergency.  Once the emergency has passed, changes must be
reviewed in a timely fashion.

Deploying code on the development cluster does not require review.
All Developers are encouraged to use the development cluster for
development, testing, and review.